-
Notifications
You must be signed in to change notification settings - Fork 27
feat(specs): add facets
query parameter available at run time
#5486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(specs): add facets
query parameter available at run time
#5486
Conversation
🪓 The generated code will be pushed at the end of the CI.Action triggered by commit Please do not push any generated code to this pull request. |
this one is expected @ClaraMuller you need to add |
Thanks @shortcuts I am not confortable modifying this, can I get your help on this ? |
Hey @ClaraMuller, actually it was the same name clashing issue as the last PR, I did some renaming and now there is no conflicts for |
@millotp it seems that @shortcuts was suggesting an other solution |
I spoke with @shortcuts, it wouldn't have worked, the issue was with redocly, not openapi-generator, so we need to fix the spec before changing the generator |
Oh I see in that case if does generate a proper parameter called |
I couldn't make it work without breaking algoliasearch lite or recommend, so the name of the model will have to stay as |
Hello @millotp |
@millotp @shortcuts is this issue introduced by this PR or has become apparent due to it? Would it be possible to see the duplicated files where they are? Any help would be appreciated as this change is required for customer testing which we have to do soon. |
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-594
Mitigation for #5477 in the meantime.
Changes included:
Add
facets
parameter as a potential value forrun
endpoint as it is allowed in the payload🧪 Test
yarn cli build specs all && yarn cli build clients javascript