Skip to content

Conversation

ClaraMuller
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-594
Mitigation for #5477 in the meantime.

Changes included:

Add facets parameter as a potential value for run endpoint as it is allowed in the payload

🧪 Test

  • CI
  • Run locally yarn cli build specs all && yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team as a code owner October 16, 2025 13:44
@ClaraMuller ClaraMuller requested review from a team, millotp and shortcuts October 16, 2025 13:44
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 16, 2025

🪓 The generated code will be pushed at the end of the CI.

Action triggered by commit 803b28bbec8b3cb6cff41102f424dd19aa2ed91c.

Please do not push any generated code to this pull request.

@ClaraMuller
Copy link
Contributor Author

Hello @millotp as a mitigation of #5477, I created this PR, but even without re-defining anything, I have some issues.

@shortcuts
Copy link
Member

shortcuts commented Oct 16, 2025

this one is expected @ClaraMuller you need to add IndexSettingsFacets to https://github.com/algolia/api-clients-automation/blob/main/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java#L32, swift have one big bundle that prevents duplicate names between its sub packages (search, composition)

@ClaraMuller
Copy link
Contributor Author

Thanks @shortcuts I am not confortable modifying this, can I get your help on this ?

@millotp
Copy link
Collaborator

millotp commented Oct 16, 2025

Hey @ClaraMuller, actually it was the same name clashing issue as the last PR, I did some renaming and now there is no conflicts for facets anymore, is this what you expected to generate ?

@ClaraMuller
Copy link
Contributor Author

@millotp it seems that @shortcuts was suggesting an other solution

@millotp
Copy link
Collaborator

millotp commented Oct 16, 2025

it seems that @shortcuts was suggesting an other solution

I spoke with @shortcuts, it wouldn't have worked, the issue was with redocly, not openapi-generator, so we need to fix the spec before changing the generator

@ClaraMuller
Copy link
Contributor Author

Oh I see in that case if does generate a proper parameter called facets (which is my goal here) let's do it that way.

aiordache
aiordache previously approved these changes Oct 17, 2025
@millotp
Copy link
Collaborator

millotp commented Oct 20, 2025

I couldn't make it work without breaking algoliasearch lite or recommend, so the name of the model will have to stay as IndexSettingsFacets to avoid other clashes

@ClaraMuller
Copy link
Contributor Author

Hello @millotp
What can Comp API do ? At the moment change is minimal I am a bit at the limit of what I can contribute autnomously.

@sfaiqh
Copy link

sfaiqh commented Oct 20, 2025

@millotp @shortcuts is this issue introduced by this PR or has become apparent due to it? Would it be possible to see the duplicated files where they are?

Any help would be appreciated as this change is required for customer testing which we have to do soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants